Skip to content

feat(yaml): store variant name in tuple and struct variants #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

feat(yaml): store variant name in tuple and struct variants #444

merged 1 commit into from
May 7, 2025

Conversation

@lemorage
Copy link
Contributor

@lemorage lemorage commented May 7, 2025

Previously, in our implementations of yaml serialization, the serialize_tuple_variant and serialize_struct_variant methods only serialized the data within the variant. They don't handle the variant's name.

cocoindex/src/utils/yaml_ser.rs

Lines 181 to 191 in cf567ce

fn serialize_tuple_variant(
self,
_name: &'static str,
_variant_index: u32,
_variant: &'static str,
len: usize,
) -> Result<Self::SerializeTupleVariant, Self::Error> {
Ok(SeqSerializer {
vec: Vec::with_capacity(len),
})
}

cocoindex/src/utils/yaml_ser.rs

Lines 208 to 216 in cf567ce

fn serialize_struct_variant(
self,
_name: &'static str,
_variant_index: u32,
_variant: &'static str,
len: usize,
) -> Result<Self::SerializeStructVariant, Self::Error> {
self.serialize_map(Some(len))
}

This PR modifies them to store variant name when serialized, closes #443.

@badmonster0 badmonster0 merged commit b1a2939 into cocoindex-io:main May 7, 2025
6 checks passed
@badmonster0
Copy link
Member

badmonster0 commented May 7, 2025

Thanks for fixing this!

@lemorage lemorage mentioned this pull request May 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@badmonster0 badmonster0 badmonster0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Keep Variant Name in YAML Serialization

2 participants

@lemorage @badmonster0